Skip to content

SEOBNRv4HM_ROM fix bug HDF5 and fmax

Roberto Cotesta requested to merge waveforms/reviews/lalsuite:seobnrv4hmrom-review into master

Description

This merge request addresses 2 minor bugs in SEOBNRv4HM_ROM:

The commit "SEOBNRv4HM_ROM: Fix bug caused by fmax = 0" fix the bug arising when generating a waveform with fmax = 0. Instead of using the maximum available frequency, as done conventionally, the model was crashing.

The commit "SEOBNRv4HM_ROM: fix bug when installing lalsuite without HDF5" fix the bug pointed here that was causing lalsuite installation to fail when HDF5 wasn't installed.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Signed off by @jonathan.gair and documented on the SEOBNRv4HM_ROM review wiki.

Edited by Maria Haney

Merge request reports