Skip to content

Revert "ComputeFstat.h: FstatOptionalArgs doesn't take ownership of any pointers"

Karl Wette requested to merge ANU-CGA/lalsuite:swig-revert-FstatOptionalArgs into master

Description

This MR reverts one commit from !1712 (merged), which changed some memory semantics of the FstatOptionalArgs struct in LALPulsar (i.e. whether the struct owns the memory of objects assigned to its fields). Reinhard has reported that this has broken existing code bases, e.g. PyFstat, which were assuming the previous memory semantics.

There's no "right" answer to what memory semantics the FstatOptionalArgs struct should have; one could make arguments for different semantics depending on how one wishes to use the struct. That said, existing code shouldn't be broken without good reason (which there isn't here) and so this change is being reverted.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Restoring previous SWIG interface behaviour assuming by existing code base. Unlikely new code depends on the new semantics as this change was only recently pushed (and yet to be released).

Review Status

n/a

Merge request reports