Skip to content

lal/lib/support/FileIO.c: include whereami.c directly

Karl Wette requested to merge ANU-CGA/lalsuite:static-whereami into master

Description

The wai_... functions should not be part of the liblalsupport.so ABI as they're really meant for internal use only.

This patch includes whereami.c directly into FileIO.c, so that wai_... functions can be compiled with static (by setting WAI_FUNCSPEC).

After this patch nm lal/lib/support/.libs/liblalsupport.so | grep wai returns nothing.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

Removes an ABI change introduced in !1746 (merged) that shouldn't have been made.

Review Status

cc @adam-mercer

Merge request reports

Loading