Skip to content

lalapps sbank: remove in-line row id generators

Kipp Cannon requested to merge (removed):silence_sbank_failures into master

Description

this replaces custom row id generator statements in sbank related programs in lalapps with calls to the table-supplied row id generators in the XML I/O library. this ensures the rows have the correct id type for the tables (integer vs ilwd:char, as required by the table definition), and fixes errors caused by trying to import modules that no longer exist.

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
  • This change removes an existing API

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

not reviewed. note that the sbank code doesn't actually work, so this patch can't be tested. it should work, but mostly the motivation is to silence import errors that are blocking other development work.

Merge request reports