Skip to content

GPU port of F-statistic, incoherent summation in Weave

Karl Wette requested to merge ANU-CGA/lalsuite:cuda-resamp-weave into master

Description

This MR provides a GPU port of the F-statistic, described in Dunn et al., Class. Quantum Grav. 39 045003 (2022). It also provides some new features for Weave, in particular a GPU port of incoherent summation over segments, which were used for the search described in Wette et al., Phys. Rev. D 103 083020 (2021).

API Changes and Justification

Backwards Compatible Changes

  • This change introduces no API changes
  • This change adds new API calls

Backwards Incompatible Changes

  • This change modifies an existing API
    • New field in struct tagFstatResults which changes its binary layout, needed for new GPU feature
    • Removal of const from a function argument in XLALExtractResampledTimeseries() and XLALCreateCrossCorrWorkspace(), needed for code refactoring
  • This change removes an existing API
    • Removal of function XLALAdd4ToFstatResults(), not used since dd480455

Review Status

@david-keitel This is obviously a lot of new code, and I don't think a detailed code review is needed at this time. You might want to have a look more at the general structure of the changes, e.g. how the GPU port has been slotted into the ComputeFstat module, API changes, etc.

Edited by Karl Wette

Merge request reports