Skip to content

Change output matrix of tracked lines from 0s and 1s to matrix of floats for tracked lines

Evan Goetz requested to merge evan-goetz/lalsuite:persist-thresh into master

Description

Rather than a matrix of 0s and 1s for determining if tracked lines are above a threshold, this MR changes the output to just give the number of standard deviations above the mean. Then the matrix can be 'thresholded' if desired in subsequent post-processing.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@ansel-neunzert should have a look, but otherwise is a straightforward change. @karl-wette or @david-keitel can give a final sign-off.

Merge request reports