Skip to content

Add ability to include a transient signal model for a heterodyned CW signal

Matthew Pitkin requested to merge matthew-pitkin/lalsuite:transient_cw into master

Description

This MR adds to the heterodyned continuous-wave signal model to allow it to include a transient window. Currently, two windows are allow: a rectangular window and an exponential decay window (consistent with those allowed for the ComputeFstatistic and Makefakedata codes).

The two main changes in this MR are:

  • allowing parameters for these transient models to be included, and correctly read-in, from pulsar .par file.
  • applying the appropriate window to the signal amplitude model.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Some checks will be detailed in the comments below and the test suite will be updated. cc @david-keitel

Edited by Matthew Pitkin

Merge request reports