Skip to content

Fix !1862 bug when compiling with -DNDEBUG

Karl Wette requested to merge ANU-CGA/lalsuite:LALMalloc-fixes into master

Description

I neglected to build !1862 (merged) with -DNDEBUG, and so missed a copy-n-paste error in a macro definition. This MR fixes the bug.

To ensure that building LALSuite with -DNDEBUG is tested in future, I've added CPPFLAGS="-DNDEBUG" to the configure line for the toplevel CI job.

I've now realised that some test scripts in LALSimulation use assert(), which would disappear with -DNDEBUG. So I've removed the change to the toplevel CI job.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

cc @adam-mercer

Edited by Karl Wette

Merge request reports