Skip to content

Cleanup lalapps/src/pulsar Makefile.am files

Karl Wette requested to merge ANU-CGA/lalsuite:LALApps-pulsar-Makefile-cleanup into master

Description

The MR is mostly a cosmetic clean up of Makefile.am files under lalapps/src/pulsar.

In doing so I noticed that codes under lalapps/src/pulsar/GCT and lalapps/src/pulsar/HoughFstat have SSE-enabled versions, that weren't built by default - I imagine these were only ever used by Einstein@Home. I'm now using the LALSUITE_CHECK_SIMD() build system to enable the SSE versions by default (if SSE is available), as is done for other codes like the F-statistic.

The MR also fully enforces the requirement that all install C programs in lalapps/src/pulsar have tests. To do that, the following programs are no longer installed (although they are still part of the build system, so should still be compilable):

  • lalapps_TwoSpect
  • lalapps_TwoSpectTemplateBank
  • lalapps_CombSearch
  • lalapps_pulsar_crosscorr

None of these codes are currently in active use. They can very easily be re-installable again when a test script is provided.

Closes #327 (closed)

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

N/A

Edited by Karl Wette

Merge request reports