Skip to content

part 2 of a large clean-up of lalmetaio and related code

Kipp Cannon requested to merge (removed):lalmetaio_cleanup_02 into master

Description

In this patch set, "new"-style I/O functions are added for sngl_inspiral, sim_ringdown and sngl_ringdown tables. All relevant calling codes are switched to the new functions. This completes the conversion of lalsuite to the integer-valued ID column format. Prior to these patches lalsuite had accumulated 3 distinct XML I/O APIs. This patch set converts lalsuite to the newest of the three, but does not yet delete the older APIs. Also, some parts of the older APIs are only used by a small number of programs (like, one), and new-style replacements are not provided for those components. In subsequent patches that remove the old APIs, those functions will be migrated into the programs that use them.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Not reviewed.

Edited by Kipp Cannon

Merge request reports