Skip to content

Move lalapps/src/lalapps utilities to LAL

Karl Wette requested to merge ANU-CGA/lalsuite:move-lalapps-utils-to-lal into master

Description

The MR moves the following utility programs in lalapps/src/lalapps to lal/bin:

  • lalapps_cache
  • lalapps_fftwf_wisdom
  • lalapps_fftw_wisdom
  • lalapps_path2cache
  • lalapps_searchsum2cache
  • lalapps_tconvert

All have been renamed with lal_ prefixes. But LALApps will still install stubs with the old lalapps_ names which will print a warning on standard error:

$ ./lalapps_tconvert 

WARNING: 'lalapps_tconvert' has been renamed to 'lal_tconvert'
WARNING: please update your scripts

1341023807

Test scripts for lal_cache, lal_path2cache, and lal_tconvert have been added, using test code from lalapps/conda/meta.yaml.in.in.

Finally lal_path2cache and lalapps_searchsum2cache were passed through 2to3 and ported to use lal.git_version.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

Closes #549 (closed)

cc @adam-mercer @jolien-creighton

Edited by Karl Wette

Merge request reports