Skip to content

Revert "Merge branch 'remove-sbank-lalapps' into 'master'"

Kipp Cannon requested to merge revert-5f73ade0 into master

Description

This is a request to restore the sbank code in lalsuite by reverting the merge request that deleted it. The suggestion to move forward on this by pressing the "Revert" button on the original merge request page was given to me when I brought this issue up on this week's R&D call (https://wiki.ligo.org/CBC/TechAgenda20220711)

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

The original code this restores is well-reviewed. This merge request is not.

Merge request reports