Skip to content

delete LALExtractFrameResponse() LALCreateCalibFrCache()

Kipp Cannon requested to merge (removed):remove_FrameCalibration_h into master

Description

This code was to support a mode of analysis in which the raw photodiode ADC channel was analyzed, instead of a calibrated h(t) channel. The former hasn't been done in a very long time, maybe not since initial ligo's 3rd run (calibrated strain frame file sets became avilable starting in S4). aLIGO's readout works differently, so even if someone wanted to, it's possible there's not even a channel equivalent to the uncalibrated ADC counts of ancient times. Furthermore, and probably for the reasons listed above, it seems no one is willing to put in the effort to XLAL-ify these functions, and their test suite seems to have been disabled for several years (if it ever worked). This patch removes the code in the continuing effort to purge lalsuite of the LALAStatus pointer.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

As explained above, the code is unused.

Review Status

Not reviewed.

Merge request reports