Skip to content

Fix negative m modes prefactor in polarisation and modes of NRSurrogate.

Samson Leong requested to merge samson.leong/lalsuite-nr-sur:Fix-neg-m-modes into master

Description

This merge request aims to fix the issue that NRSur7dq4 cannot produce the correct physical waveform when the input m2 > m1.

Targetting at these two functions: XLALSimInspiralPrecessingNRSurModes and XLALSimInspiralPrecessingNRSurPolarizations.

It was reported in the Waveform call on 21/07/22. [dcc]
This merge request does not fix the phase issue of the IMRPhenom models mentioned at the end.

Remark: This is the same merge request as !1919 (closed), but more up-to-date with the master branch.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports