Skip to content

PulsarCrossCorr_v2: merge in lattice development branch

John Whelan requested to merge LMXBCrossCorr/lalsuite:crosscorr-lattice-dev-clean into master

Description

This branch includes the template lattice routines for the cross-correlation search for continuous waves. It includes the two commits which were used and reviewed for the O3 Sco X-1 CrossCorr search.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

This adds the header TascPorbTiling.h to lalpulsar, which includes the new function XLALSetLatticeTilingPorbEllipticalBound()

It also adds new arguments to the executable lalapps_pulsar_crosscorr_v2 in lalapps.

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

This new functionality has been reviewed as part of the O3 Sco X-1 CrossCorr review by @graham.woan and @edward.daw https://wiki.ligo.org/CW/CrossCorrO3Review

Merge request reports