Skip to content

lal*/conda/meta.yaml.in.in: run install-python.sh with same script_env as build.sh

Karl Wette requested to merge ANU-CGA/lalsuite:conda-fix-script-env into master

Description

Fixes lal*/conda/meta.yaml.in.in by adding the same script_env (containing CI_COMMIT_TAG, CI_PIPELINE_SOURCE, and GITLAB_CI) to each install-*.sh script, the same as for the build.sh scripts.

Both scripts need these variables set to decide on which flags to pass to ./configure. In particular, setting -UNDEBUG inconsistently can lead to segfaults (#573 (closed)) because the LAL memory functions are not consistently enabled/disabled.

conda-build raises an error for unset variables in script_env for install-*.sh: ValueError: env var 'CI_COMMIT_TAG' specified in script_env, but is not set This may be a bug as the same error isn't raised for build.sh.

To ensure CI_COMMIT_TAG is passed to all scripts, need to make sure CI_COMMIT_TAG is set before calling conda-build, then in scripts only test whether CI_COMMIT_TAG is null, not whether it is unused.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

Closes #573 (closed) as being the immediate cause of the segfault (but see #573 (comment 576406))

Edited by Karl Wette

Merge request reports