Skip to content

test_hwinject.sh: kill lalpulsar_hwinject if it hangs after 60 seconds

Karl Wette requested to merge ANU-CGA/lalsuite:kill-hanging-test-hwinject into master

Description

I've noticed a few CI jobs timing out while running the lalpulsar/bin/HWInjection/test_hwinject.sh test script (all coverage jobs for some reason):

I can't reproduce this locally, but I can imagine that lalpulsar_hwinject might hang if one of the lalpulsar_Makefakedata_v4 commands it forks falls over or does run synchronously.

The MR runs lalpulsar_hwinject in a subshell with ulimit -t 60 set; so after 60 seconds bash will kill the process. To compensate test_hwinject.sh will try to run lalpulsar_hwinject up to 5 times, before giving up. At least this way, worst case the CI job will fail after ~5 minutes and then be re-run.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

@david-keitel to review and approve

Merge request reports