Skip to content

Run make check -C bin in conda/install-bin.sh

Karl Wette requested to merge ANU-CGA/lalsuite:conda-install-bin-make-check into master

Description

This implements @duncanmmacleod 's suggestion (!1904 (comment 574217)) of running make check -C bin from the conda/install-bin.sh script (which installs binaries). This extends !1904 (merged) which implemented this just for LALPulsar. Aside from LALPulsar, this picks up a few extra test scripts in LAL, for which lal/conda/meta.yaml.in.in needs some dependencies added.

lalinference/conda/install-bin.sh is a separate script, so I also added make check -C bin there as well. In doing so I noticed that lalinference/conda/meta.yaml.in.in was missing the right script_env for install-bin.sh (cf. !1929 (merged)) so this is fixed up as well.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

cc @duncanmmacleod

Merge request reports