Skip to content

Fixes incorrect behaviour in XLALSimIMREOBGenerateQNMFreqV2fromFinal

Serguei Ossokine requested to merge serguei.ossokine/lalsuite:qnm_patch into master

Description

This MR fixes incorrect behaviour of XLALSimIMREOBGenerateQNMFreqV2fromFinal and addresses #574.

This is done by fixing the incorrect if statement logic so that an error is thrown if the QNM one desires is not available.

API Changes and Justification

There are no API changes

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Needs a look from WF chairs, tagging @maria.haney @geraint.pratten @vijay.varma

Merge request reports