Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L lalsuite
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 114
    • Issues 114
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 37
    • Merge requests 37
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • lalsuite
  • Merge requests
  • !1949

Common top-level directory for build infrastructure files

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Karl Wette requested to merge ANU-CGA/lalsuite:common-top-level-dir into master Aug 10, 2022
  • Overview 8
  • Commits 5
  • Pipelines 0
  • Changes 227

Description

The top level of LALSuite has accumulated a number of directories for common build infrastructure files, and it's starting to be a little cluttered. In addition, the top-level gnuscripts/ directory is being used to hold other build infrastructure files, such as debian/ and various maintenance scripts, which aren't part of Autotools and should have a home elsewhere.

This MR creates a top-level common/ directory to house the common conda/, doxygen/, gnuscripts/debian/, swig/, and test/ directories. I've also added a common/maintainer-scripts/ directory for various maintenance scripts. A common/README.md describes each directory in common/, subsuming the existing README.mds in the common/ subdirectories. All symlinks have been updated.

Moving the existing top-level directories to common/ shouldn't cause and problems in the build system; since the files under common/ are symlinked into the lal.../ directories, as far as the library-level build systems are concerned the files haven't actually been moved. (The top-level gnuscripts/ itself cannot be moved as it must have the same layout relative to configure.ac as in the lal.../ directories.)

Finally the top-level directory docker/ has been renamed to .docker/ consistent with the existing .gitlab-ci-*.Dockerfile files. (FWIW AFAICT .docker/startup isn't currently used anywhere.)

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

cc @adam-mercer @duncanmmacleod

Edited Aug 10, 2022 by Karl Wette
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: common-top-level-dir