Restore LALPulsar dependency to LALApps
Description
At the request of @david-keitel this restores the dependency on LALPulsar to LALApps.
LALApps still contains executable stubs with the old lalapps_... names for CW codes. Restoring the LALPulsar dependency ensures that LALPulsar is available to provide the new lalpulsar_...-named executables which the old stubs fall back to.
A minimal test has been added to lalapps/src/pulsar/Makefile.am to check that the new lalpulsar_...-named executables are available. It's written as an installcheck (so only runs after everything has been installed) because it's too difficult to determine where the lalpulsar_... are located prior to being installed. It also doesn't check every lalpulsar_... executable as not all of them may be installed (e.g. if LALPulsar is not compiled with cfitsio/LALSimulation/LALInference support) but instead checks a few key executables which are guaranteed to be installed.
I don't believe it's possible in general to run a test for LALPulsar executables while LALApps is being built, because at that point only build dependencies are installed, not regular package dependencies. (I could add LALPulsar as a build dependency for LALApps, but that would be pointless as it wouldn't test that LALPulsar executables are installed when LALApps is actually installed.) The conda test section in meta.yaml.in.in is the only place where I believe a post-installation test is possible, so I've added checks for a few representative LALPulsar executables there.
Closes #589 (closed)
API Changes and Justification
Backwards Compatible Changes
-
This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions -
This change adds new classes/functions/structs/types to a public C header file or Python module
Backwards Incompatible Changes
-
This change modifies an existing class/function/struct/type definition in a public C header file or Python module -
This change removes an existing class/function/struct/type from a public C header file or Python module
Review Status
This should be backported to the next release as well to make sure the next round of packages are in sync.