Skip to content

ComputeFstat: pass sourceDeltaT from FstatOptionalArgs thru to XLALCWMakeFakeData()

Karl Wette requested to merge ANU-CGA/lalsuite:ComputeFstat-sourceDeltaT into master

Description

This is needed when trying to inject signals with high spindowns, very fast orbital periods, etc. The default behaviour when sourceDeltaT == 0 is the same as before, so this should be backward compatible.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

This is needed to support new usage of the F-statistic code, which requires passing it more information. There's no way to add fields to a C struct without breaking strict ABI compatibility.

Review Status

cc @david-keitel

Merge request reports