gcc 12 fixes

Description

Debian's upgrade to gcc 12 has brought with it improvements to gcc's static code analysis features which have revealed more bugs in lalsuite. These cause it to be uncompilable with -Wall -Werror. These patches make the errors go away, but they do not "fix" the codes, which in many cases appear to be seriously broken (multiple fclose() on the same file, nonsensical NULL pointer checks, ...). In some cases they are obsolete LALStatus based codes that appear to be abandonware.

API Changes and Justification

Backwards Compatible Changes

• This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
• This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

• This change modifies an existing class/function/struct/type definition in a public C header file or Python module
• This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Not reviewed.

=== EDIT DK ===

• closes #536 (closed)
• closes #594 (closed)