Skip to content

Weave: should exit if requested after calling XLALUserVarReadAllInput()

Karl Wette requested to merge ANU-CGA/lalsuite:weave-fix-ui-parse into master

Description

Fix 2 minor bugs in Weave.c and WeaveSetup.c; after calling XLALUserVarReadAllInput() one should immediately check should_exit and exit the program if requested.

This is to avoid running any user input checks which may not work correctly. For example, if the user asked for --help or --version, some user input variables -- even required ones -- may not be set correctly, and so running user input checks e.g. calling strcmp() on a string user input variable which is NULL could segfault.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

cc @david-keitel

Merge request reports