Skip to content

Commits for LALPulsar release request #620

Karl Wette requested to merge ANU-CGA/lalsuite:lalpulsar-release into release-20220823

Description

This MR contains the commits for a backward-compatible LALPulsar release requested in #620 (closed). It includes:

Some commits from !2009 (merged) didn't apply cleanly and needed to be resolved manually. That said, I've confirmed the final branch is merge-compatible with the current master 82d93aab, i.e. I can merge this branch into master cleanly, and vice versa.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

!2021 (merged) adds some new functions.

I ran ABICC between the last LALSuite release and this branch, which gave this report. The only issue it highlights is the removal of the function CheckIfSFDBInScienceMode(); this function isn't actually removed, but was re-declared static in !2009 (merged) as it's an internal function. It's never been declared in the public LALPulsar headers, so doesn't qualify as an ABI break.

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

cc @adam-mercer

cc @david-keitel @evan-goetz Please confirm this contains all the changes you need for PyFstat / Fscans.

Merge request reports