Skip to content

SWIG: more verbose assertions in tests

Karl Wette requested to merge ANU-CGA/lalsuite:swig-more-verbose-asserts into master

Description

This MR upgrades the SWIG wrapper test scripts in lal*/swig to use more verbose assertions, so make diagnosing failures easier.

For Python, I've upgraded the tests to use pytest, which gives more verbose assert statements for free.

For Octave, I've used its 2-argument version assert(OBSERVED, EXPECTED) where possible, as that gives more verbose output on failures.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

cc @duncanmmacleod @adam-mercer

Merge request reports

Loading