Skip to content

Fix for #640

Cecilio Garcia-Quiros requested to merge cecilio.garcia-quiros/lalsuite:xhm-gps-sequence-erro into master

Description

This is to fix the issue described in #640 (closed).

The problem only appeared when using ChooseFDWaveformFrequencySequence which is not a common functionality. Nothing in the waveform changes. The issue is that in FrequencySequence no shift in time of coalescence should be applied. For the other IMRPhenomX models a similar if condition as the one applied here is used.

@maria.haney @geraint.pratten

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This notebook checks that SimInspiralChooseFDWaveformSequence reproduces the result of SimInspiralChooseFDWaveform (taken from the tests carried out for the phenomx review).

Test_XHM_FrequencySequence.ipynb

Edited by Maria Haney

Merge request reports