Skip to content

fix matplotlib mathtext.fallback deprecation

Ethan Marx requested to merge ethan.marx/lalsuite:matplotlib-deprecation into master


Reopened version of #641 (closed) with template

mathtext.fallback_to_cm = True rcparam was deprecated in Matplotlib 3.3 in favor of mathtext.fallback = "cm". This currently effects the igwn-py39 environment (and likely others).

For example, running

conda activate igwn-py39
>>> from lalinference import bayespputils
KeyError: 'mathtext.fallback_to_cm is not a valid rc parameter (see rcParams.keys() for a list of valid parameters)'

I suspect this will require bumping matplotlib minimum version to 3.3, which seems like a large jump from the current 1.2.0

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

This change does not effect any API components#### Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Ethan Marx

Merge request reports