Skip to content

Add PhenomXAS duration function

Geraint Pratten requested to merge geraint.pratten/lalsuite:phenomx_dur into master

Description

This adds a function to calculate the chirp time/duration of PhenomXAS waveforms in analogy with SimIMRPhenomDChirpTime.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

This is a small function that should be quick to review. I am in contact with the review chair to sign off on this commit.

Merge request reports