Skip to content

fix naming check for narrow-band SFTs with band < 1 Hz

David Keitel requested to merge david-keitel/lalsuite:narrowband-SFTs-fix-band-check into master

Description

Simple fix for #645 (closed) just making the error check less strict (by checking the non-integer remnant field). Also adds another execution to the test script for this case, which for simplicity I've left at a simple "does not fail". Detailed per-bin comparisons are already done on the wider-band case.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

for @karl-wette to take a look when available again

Merge request reports