Skip to content

MFDv5: --noiseSFTs and --SFTWindowType compatibility

David Keitel requested to merge david-keitel/lalsuite:MFDv5-window-uvars into master

Description

Closes #644 (closed) by implementing a helper function XLALCompareSFTWindows() so that one can now legally pass window type and parameter to MFDv5 at the same time as --npiseSFTs, as long as they're consistent with what's stored in the noiseSFTs header, but still get an error for anything inconsistent. Also reordered the corresponding checks in MFDv5 to be more readable now that all branches require separate handling (first AND, then OR, then error; instead of starting with a XOR) and extended the test script.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

for @karl-wette's eyes

Merge request reports