Skip to content

Correct conda zlib host requirement for LAL

Duncan Macleod requested to merge duncanmmacleod/lalsuite:conda-zlib into master

Description

This MR addresses as bug in the conda packaging for LAL. zlib is the conda package that provides the 'development' files for libzlib (the library), including pkgconfig files, so we need that in all requirements/host lists. At runtime we just need libzlib which provides the library[^1].

[^1] we don't actually explicitly need that since a runtime requirement is forced upon us by the build, but I like to be explicit

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports