Skip to content

MFDv4: --noiseSFTs and --SFTWindowType compatibility

David Keitel requested to merge david-keitel/lalsuite:MFDv4-window-uvars into master

Description

@karl-wette in !2082 (merged) I hadn't noticed that MFDv4 has the same issue as MFDv5. Fixed here now with basically the same diff; the only difference is that due to the different cfg struct (window_type being a CHAR * here instead of a const CHAR * in MFDv5, for some reason), a few extra XLALStringDuplicate calls are needed.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

tbd

Edited by David Keitel

Merge request reports