Skip to content

Test for improperly allocated REAL8VectorSequence in spec_avg_long

Evan Goetz requested to merge evan-goetz/lalsuite:fix-nomem into master

Description

Keith ran into a problem that spec_avg_long had a segmentation fault when running over O3 SFTs. I tracked this down to an attempted very large allocation of a REAL8VectorSequence. This MR implements a check on the size of this to verify that it was fully allocated at runtime. If not, it returns an error and provides the user with some guidance about what they can do about it.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

@keith-riles, @david-keitel, or @karl-wette could have a look at this simple change.

Merge request reports