Skip to content

Draft: Add SEOBNRv5_ROM

Lorenzo Pompili requested to merge waveforms/reviews/lalsuite:SEOBNRv5HMROM-review into master

Description

Adds the waveform model SEOBNRv5_ROM. Currently under review, wiki page: https://git.ligo.org/waveforms/reviews/seobnrv5hm_rom

Draft MR so that interested people can more easily follow further development.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Currently under review, wiki page: https://git.ligo.org/waveforms/reviews/seobnrv5hm_rom

Merge request reports