Skip to content

lal/bin/cache.c: advance arg so that 1st cache glob is not processed twice

Karl Wette requested to merge ANU-CGA/lalsuite:fix-lal-cache-duplicate into master

Description

lal_cache currently generates a duplicate entry for the 1st cache glob passed on the command line, because the 1st cache glob is processed twice (on lines 35 and 39 of cache.c respectively). This MR advances arg by one on line 35, so that the 1st cache glob is not processed again. It also adds a test to test_cache.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Merge request reports