Skip to content

Make sure that the frequency sequence obeys the Mf_max criterion.

Geraint Pratten requested to merge geraint.pratten/lalsuite:phenomx_fmax_fs into master

Description

Adds a sanity check to the IMRPhenomX* waveform generator to make sure that frequencies > Mf_max (default is Mf = 0.3) are set to zero. Without this, the frequency sequence waveforms are slower than expected based on the number of frequency points relative to the default uniform grid waveforms.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Tests show that the frequency sequence waveforms are identical to the uniform grid waveforms. E.g. attached notebook: check_fmax.pdf

Edited by Maria Haney

Merge request reports