Skip to content

FTI (formerly FTA) inspiral test of GR

Jan Steinhoff requested to merge aei-tgr/lalsuite:FTI_MR into master

Description

Adds the FTI (formerly called FTA) inspiral test of GR to lalsimulation and lalinference. This has been extensively used and tested through past observing runs under the name FTA test (for flexible theory agnostic), but not merged to master until now. The code was further extended for O4 and renamed to FTI test (for flexible theory independent). The test can be used with any frequency-domain nonprecessing waveform as a GR baseline and has been mainly used with the SEOBNR waveform family in past publications. The method is described in arXiv:2203.13937.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Negative PN coefficients are added to struct tagPNPhasingSeries as REAL8 vneg[PN_PHASING_SERIES_MAX_ORDER+1] in lalsimulation/lib/LALSimInspiral.h for the dipole radiation test. This is an addition to the struct and should not modify existing functionality.

Review Status

The review of this code handled by the TGR group is complete.

Reviewers: @michalis-agathos @stanislav.babak

Reviewees: @elise.sanger @jan.steinhoff @alessandra-buonanno

The latest review wiki for the extensions for O4 can be found here. The notable changes compared to O3 are:

  • extension to higher mode nonprecessing waveforms
  • where applicable, split into nonspinning, spinning, and full normalizations for the PN deviation coefficients
  • extension to spin-induced quadrupole-moment test

The old review wiki of the FTA code used for the TGR papers up to O3 can be found here.

Edited by Jan Steinhoff

Merge request reports