Skip to content

Update SEOBNRv5_ROM filename

Lorenzo Pompili requested to merge waveforms/reviews/lalsuite:update_rom_filename into master

Description

The ROM data file for the SEOBNRv5_ROM model has been renamed SEOBNRv5ROM_v1.0.hdf5 to follow the requirements for data distribution. The data file in lalsuite-extra will be updated shortly.

This patch updates the filename in the few places where it appeared and adds a check that the file opened has the corresponding value set for CANONICAL_FILE_BASENAME as required.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

The model is reviewed (https://git.ligo.org/waveforms/reviews/seobnrv5hm_rom), but these changes should be approved by the review chair (@geraint.pratten ).

Merge request reports