Skip to content
Snippets Groups Projects

SWIG: move flat namespace flag for Python wrappings to its own variable

Merged Karl Wette requested to merge (removed):SWIG-config-cleanup into master

Description

  • Document link to page in waveform review wiki why flag is needed for !2003 (merged)
  • Keep EXTRA_SWIG_{OCTAVE,PYTHON}_LDFLAGS for arbitrary extra flags
  • Also remove nonexistent SWIG_PYTHON_LIBS variable in lalinspiral/python/lalinspiral/Makefile.am

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

cc @adam-mercer

Merge request reports

Merged results pipeline #522590 passed with warnings

Merged results pipeline passed with warnings for a2095fdc

Test coverage 28.63% (0.00%) from 1 job
Approval is optional

Merged by Adam MercerAdam Mercer 1 year ago (May 5, 2023 7:23pm UTC)

Merge details

  • Changes merged into with 2f58861f.
  • Deleted the source branch.

Pipeline #524155 failed

Pipeline failed for 2f58861f on master

Test coverage 28.63% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading