Add the --gaps flag to lalpulsar_MakeSFTDAG.py

Description

This MR adds the --gaps flag to gw_data_find so that it will emit a non-zero return if the frame list that is returned does not cover the requested time. This should hopefully allow condor to catch when there are missing frames and cause the workflow to fail properly. Right now if the cache file produced does not have the requested coverage, the MakeSFTs step is the one the fails, but really it should fail on the datafind step.

I also took the opportunity to improve the code slightly by using f-strings instead of the format() method

API Changes and Justification

Backwards Compatible Changes

• This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
• This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

• This change modifies an existing class/function/struct/type definition in a public C header file or Python module
• This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Once the test passes @ansel-neunzert can have a look at this for review

lalpulsar/bin/MakeData/lalpulsar_MakeSFTDAG.py

@@ -448,29 +448,25 @@ makesfts_sub = os.path.join(path_to_dag_file, 'MakeSFTs.sub')
 # create datafind.sub
 if not args.cache_file:
     with open(datafind_sub, 'w') as datafindFID:
-        datafindLogFile = '{}/datafind_{}.log'.format(args.log_path,
-                                                          dag_filename)
+        datafindLogFile = f'{args.log_path}/datafind_{dag_filename}.log'
         datafindFID.write('universe = vanilla\n')
-        datafindFID.write('executable = {}\n'.format(dataFindExe))
+        datafindFID.write(f'executable = {dataFindExe}\n')
         if not args.datafind_match:
             dataFindMatchString = ''
         else:
-            dataFindMatchString = '--match {}'.format(args.datafind_match)
+            dataFindMatchString = f'--match {args.datafind_match}'
         datafindFID.write('arguments = -r $ENV(LIGO_DATAFIND_SERVER) ')
         datafindFID.write('--observatory $(observatory) --url-type file ')
         datafindFID.write('--gps-start-time $(gpsstarttime) ')
-        datafindFID.write('--gps-end-time $(gpsendtime) --lal-cache ')
-        datafindFID.write('--type $(inputdatatype) {}\n'.format(
-            dataFindMatchString))
+        datafindFID.write('--gps-end-time $(gpsendtime) --lal-cache --gaps ')
+        datafindFID.write(f'--type $(inputdatatype) {dataFindMatchString}\n')
         datafindFID.write('getenv = True\n')
         datafindFID.write('request_disk = 5MB\n')
-        datafindFID.write('accounting_group = {}\n'.format(args.accounting_group))
-        datafindFID.write('accounting_group_user = {}\n'.format(
-            args.accounting_group_user))
-        datafindFID.write('log = {}\n'.format(datafindLogFile))
-        datafindFID.write('error = {}/datafind_$(tagstring).err\n'.format(
-            args.log_path))
-        datafindFID.write('output = {}/'.format(args.cache_path))
+        datafindFID.write(f'accounting_group = {args.accounting_group}\n')
+        datafindFID.write(f'accounting_group_user = {args.accounting_group_user}\n')
+        datafindFID.write(f'log = {datafindLogFile}\n')
+        datafindFID.write(f'error = {args.log_path}/datafind_$(tagstring).err\n')
+        datafindFID.write(f'output = {args.cache_path}/')
         datafindFID.write('$(observatory)-$(gpsstarttime)-$(gpsendtime).cache\n')
         datafindFID.write('notification = never\n')
         datafindFID.write('queue 1\n')