Fix missing approximant name in "lalSimulationApproximantNames" list

Description

There is a missing entry when trying to loop over the approximant name list.

for (int a = 0; a < Approximant::NumApproximants; ++a) {
        const char *s = XLALSimInspiralGetStringFromApproximant((Approximant) a);
        std::cout << s << std::endl;
}

I updated the list of approximant name (conversion from type enum to string) in LALSimInspiral.c. SpinTaylorT2 was missing and SpinTaylor5 was in the wrong location in the list.

API Changes and Justification

Backwards Compatible Changes

• This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
• This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

• This change modifies an existing class/function/struct/type definition in a public C header file or Python module
• This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status