Allow per-library fallback LAL data path for XLALFileResolvePathLong()

Description

Detailed description of the changes, why they are being made, etc... Also indicate appropriate tickets and tests that have been run to determine that the changes work as intended and do not introduce other problems.

API Changes and Justification

• XLALFileResolvePathLong() replaces fallbackdir with fallbackpath
  • May contain either absolute or relative (to liblalsupport.so) paths
• LALSUITE_WITH_FALLBACK_DATA_PATH (replaces LAL_WITH_DATA_PATH) defines LAL_FALLBACK_DATA_PATH to fallback LAL data path
  • Defaults to $(pkgdatadir), same as for fallbackdir argument
• New macro XLAL_FILE_RESOLVE_PATH() passes LAL_FALLBACK_DATA_PATH to XLALFileResolvePathLong(), so each library gets its own fallback path
  • Not designed to be used outside of LALSuite; libraries implement their own functions (e.g. XLALReadEphemerisFile(), XLALSimReadDataFileOpen()) which call XLAL_FILE_RESOLVE_PATH() internally
• Non-inline XLALFileResolvePath() and XLALPulsarFileResolvePath() wrappers kept to avoid breaking ABI
• .gitlab-ci.yml: add finding data files test to lalpulsar_longtests

Backwards Compatible Changes

• This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
• This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

• This change modifies an existing class/function/struct/type definition in a public C header file or Python module
• This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

n/a p

assigned to @karl-wette

requested review from @adam-mercer

@adam-mercer This is designed to be a non-API/ABI breaking change, but let me know if you spot any issues.

This will eventually be used to close out #675 (closed).

added apinone infra_autotools infra_gitlab lal lalapps lalburst lalframe lalinference lalinspiral lalmetaio lalpulsar lalsimulation labels

approved this merge request

marked the checklist item This change does not modify any class/function/struct/type definitions as incomplete

marked the checklist item This change adds new classes/functions/structs/types as completed

I changed the backwards comaptible changes section, this adds XLAL_FILE_RESOLVE_PATH to FileIO.h. As there's new things being added to the headers this will be a forwards incompatible change, i.e. a minor version bump so no backwards incompatible changes.

@maria.haney @geraint.pratten @vijay.varma Can you please take a look at the LALSImulation changes, they are minor and result in no functional changes so I can't see this leading to any concerns.

added apiminor label and removed apinone label

@karl-wette thanks for this, but I don't quite follow why you've replaced the XLALPulsarFileResolvePath calls with the generic XLAL_FILE_RESOLVE_PATH? Even if it's just a trivial wrapper for now, isn't it better for future maintainability to have it called that way within lalpulsar?

@adam-mercer something seems to have gone wrong with approvals here. Somehow the lalpulsar and lalinference approvals show as required only when expanding the dropdown, and the button says "additionally", but then further down still the usual "Merge blocked: all required approvals must be given.". Do you know what that "invalid rule" auto-approve is about?

changed title from Per-library fallback LAL data path for XLALFileResolvePathLong() to Allow per-library fallback LAL data path for XLALFileResolvePathLong()

changed the description

approved this merge request

resolved all threads

approved this merge request

Seems like now we got a "Ready to merge!" green light after Maria approved, so despite the messed-up display of approvals, the actual procedure still works as expected.

@david-keitel Yes, AFAICT the actual approval process still works properly, it's just the GUI widget which is incorrect.

Thanks all for the approvals, I'll merge now.

mentioned in commit fd9cf7e3

merged