Skip to content

Adding updated LIGO-India (Aundha) coordinates into LAL

Aditya Vijaykumar requested to merge aditya.vijaykumar/lalsuite:LI-coordinates into master

Description

Now that the LIGO-India (Aundha) project is approved and the coordinates are public, I wanted to implement these in LAL.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

  • Currently, LIGO India (old coordinates) are implemented in LAL as I1, whereas the new name is supposed to be A1. However A1 is already in use for the (defunct, AFAIK) ALLEGRO detector, and hence there is duplication. What would be the right thing to do in this case? Should I assign a different name to ALLEGRO, or do away with it altogether, or something else entirely?

Review Status

Please provide details on any reviews related to this change and and the associated reviewers.

Edited by Aditya Vijaykumar

Merge request reports