Skip to content

Fix swap of tidal deformabilities in PhenomXP_NRTidalv2

Marta Colleoni requested to merge marta.colleoni/lalsuite:fix_swap into master

Description

This MR introduces some fixes for the XP_NRTidalv2 code, detailed below:

  • it solves an issue with the swap of tidal deformabilities when m_1<m_2 and multibanding is ON. This change does not affect the current behaviour of the code when m_1>m_2, nor PhenomXAS_NRTidalv2.
  • it introduces an additional sanity check on the inspiral SpinTaylor angles. This check triggers the fallback to MSA angles in some cases where the backward PN integration stops slightly above the minimum frequency (this would currently trigger a XLAL hard error instead of a fallback+warning).
  • it fixes a memory leak introduced by the PhenomXO4a MR, where some lines of the original XP_NRTidalv2 implementation were accidentally deleted. The change addresses this MR.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Link to review wiki.

Edited by Marta Colleoni

Merge request reports