Skip to content

PhenomXO4 Alpha Angle and Antisymmetry Fixes

Jonathan Thompson requested to merge waveforms/reviews/lalsuite:phenomXO4-2023-04-27 into master

Description

This merge adds the following small changes to the PhenomXO4a model code:

  • Change to the alpha precession angle Ansatz to reduce sharp features outside calibration region
  • Bugfix to antisymmetry code and fix to allow the antisymmetry for equal-mass superkick cases

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

Additional tests were run for the angle changes, and notebooks used in the original model review were re-run where relevant. Changes have been signed off by the original model review team.

Edited by Jonathan Thompson

Merge request reports