Skip to content

Improve multi-channel MakeSFTs tests

Karl Wette requested to merge ANU-CGA/lalsuite:makeMultiChFrame-check-data into master

Description

  • makeMultiChFrame.c: write different (scaled) data between Adc/Proc/Sim channels. Previously, these channels all wrote the same data identical to the input frame. Now, only the Adc channels are identical to the input frame, whereas the Proc and Sim channels are scaled by arbitrary constants.
  • testMakeSFTsMultiChFrame.sh: compare equivalent SFTs made from different frames/channels. Previously, these tests just checked for the existence of generated SFTs, but not whether their contents were correct. The test script now compares SFTs which should be equivalent:
    • SFTs generated from the input frame by MFDv5, versus SFTs generated from the Adc channels in the multi-channel frame;
    • SFTs generated from the REAL8 vs REAL8 versions of the Proc and Sim channels in the multi-channel frame.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

cc @evan-goetz

Merge request reports