Skip to content

PulsarCrossCorr_v2: Allow resampling pipeline to use sheared coordinates

John Whelan requested to merge LMXBCrossCorr/lalsuite:crosscorr_resamp_sheared_grid into master

Description

The addition of resampling as described in Meadors et al, PRD 97, 044017 (2018) to the cross-correlation pipeline works in the standard orbital parameter space coordinates of projected semimajor axis asini, orbital period Porb, and time of ascension Tasc. This branch extends the pipeline to work with the "sheared" period coordinate Ptilde, defined in Wagner et al, CQG 39, 075013 (2022), whose prior uncertainty is uncorrelated with that of Tasc, allowing the full search area to be enclosed in a smaller rectangular box.

Note that this does not implement the more sophisticated template lattice, just a grid in the sheared coordinates.

This branch also makes the specification of mismatch for the search grid required, rather than silently defaulting to 0.1 in each direction.

API Changes and Justification

Only to functions internal to lalapulsar_crosscorr_v2 itself.

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

The CrossCorr resampling code has not been reviewed.

Merge request reports