Skip to content

Fix lalpulsar_MakeSFTs for multiple channels in a row with too-low-sampling frequency

Evan Goetz requested to merge evan-goetz/lalsuite:fix-lowf-chans into master

Description

This MR fixes a minor bug where if multiple channels sequentially in a list have too-low-sampling frequency, then only the first will be skipped while subsequent channels with the same sampling frequency will not be skipped, even though they should be. To fix this, I completely remove the allocated window, SFT FFT data vector, and SFT FFT plan. This enforces the check on the channels and causes those with too-low-sampling frequency to be skipped.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

If any of the Backwards Incompatible check boxes are ticked please provide a justification why this change is necessary and why it needs to be done in a backwards incompatible way.

Review Status

I have checked that this change now correctly skips channels with too-low-sampling frequency.

Merge request reports