Skip to content

FITSFileIO: write HDU names to both "HDUNAME" and "EXTNAME" keys

Karl Wette requested to merge ANU-CGA/lalsuite:FITSFileIO-HDU-names into master

Description

Some LALPulsar codes (e.g. Weave) write data to FITS files. FITS files are divided into tables/images known as HDUs. An HDU can be given a name by assigning a metadata key, which is called either HDUNAME or EXTNAME. The LALPulsar FITSFileIO module has always used the former (HDUNAME) but some packages (e.g. astropy) only recognise the latter (EXTNAME). For maximum compatibility, this MR modified the FITSFileIO module to write both keys.

API Changes and Justification

Backwards Compatible Changes

  • This change does not modify any class/function/struct/type definitions in a public C header file or any Python class/function definitions
  • This change adds new classes/functions/structs/types to a public C header file or Python module

Backwards Incompatible Changes

  • This change modifies an existing class/function/struct/type definition in a public C header file or Python module
  • This change removes an existing class/function/struct/type from a public C header file or Python module

Review Status

@david-keitel to review

Merge request reports